perf(bulk-api-tester): optimize draft saving, share link creation, and combining with parallel multipart streaming and instant hard links

This commit is contained in:
2026-10-28 16:24:28 +05:30
parent ce75adb467
commit 2fd2c5e582
4 changed files with 643 additions and 239 deletions
+166
View File
@@ -6,6 +6,7 @@ import (
"encoding/hex"
"encoding/json"
"fmt"
"io"
"log/slog"
"net/http"
"os"
@@ -19,6 +20,18 @@ import (
var validIDRegex = regexp.MustCompile(`^[a-zA-Z0-9_\-]+$`)
func isSuccessStatus(status any) bool {
switch v := status.(type) {
case float64:
return int(v) >= 200 && int(v) < 300
case int:
return v >= 200 && v < 300
case string:
return strings.HasPrefix(v, "2")
}
return false
}
type ComparisonItem struct {
Index int `json:"index"`
Status any `json:"status"`
@@ -124,6 +137,12 @@ func createComparisonShareHandler(w http.ResponseWriter, r *http.Request) {
// Set 500MB limit on request body for batches of images
r.Body = http.MaxBytesReader(w, r.Body, 500*1024*1024)
// High-speed direct binary streaming via multipart
if strings.HasPrefix(r.Header.Get("Content-Type"), "multipart/form-data") {
handleMultipartShare(w, r)
return
}
var req ShareRequest
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
slog.Error("failed to decode share request", "error", err)
@@ -363,3 +382,150 @@ func comparePageHandler(w http.ResponseWriter, r *http.Request) {
w.Write(htmlBytes)
}
func handleMultipartShare(w http.ResponseWriter, r *http.Request) {
mr, err := r.MultipartReader()
if err != nil {
slog.Error("failed to create multipart reader", "error", err)
writeJSON(w, http.StatusBadRequest, map[string]any{"success": false, "error": "Invalid multipart payload"})
return
}
shareID := fmt.Sprintf("cmp_%x_%s", time.Now().Unix(), randomHexString(4))
compDir := filepath.Join("data", "bulk-api-tester", "comparisons", shareID)
imagesDir := filepath.Join(compDir, "images")
if err := os.MkdirAll(imagesDir, 0755); err != nil {
slog.Error("failed to create comparison directory", "dir", compDir, "error", err)
writeJSON(w, http.StatusInternalServerError, map[string]any{"success": false, "error": "Failed to create storage directory"})
return
}
var metaReq ShareRequest
filesMap := make(map[string]string) // formName -> savedFilename
for {
part, err := mr.NextPart()
if err == io.EOF {
break
}
if err != nil {
slog.Warn("error reading multipart part", "error", err)
break
}
formName := part.FormName()
if formName == "meta" {
metaBytes, _ := io.ReadAll(part)
json.Unmarshal(metaBytes, &metaReq)
part.Close()
continue
}
if strings.HasPrefix(formName, "before_") || strings.HasPrefix(formName, "after_") {
fileName := part.FileName()
ext := strings.ToLower(filepath.Ext(fileName))
if ext == "" {
ext = ".png"
}
saveName := fmt.Sprintf("%s%s", formName, ext)
filePath := filepath.Join(imagesDir, saveName)
outFile, err := os.Create(filePath)
if err == nil {
io.Copy(outFile, part)
outFile.Close()
filesMap[formName] = saveName
} else {
slog.Warn("failed to write multipart image", "path", filePath, "error", err)
}
part.Close()
continue
}
part.Close()
}
var items []ComparisonItem
var totalLatency int64
successCount := 0
errorCount := 0
for i, it := range metaReq.Items {
itemIndex := it.Index
if itemIndex <= 0 {
itemIndex = i + 1
}
cItem := ComparisonItem{
Index: itemIndex,
Status: it.Status,
Latency: it.Latency,
InputFilename: it.InputFilename,
OutputFilename: it.OutputFilename,
ContentType: it.ContentType,
TextContent: it.TextContent,
}
if isSuccessStatus(it.Status) {
successCount++
} else {
errorCount++
}
totalLatency += it.Latency
beforeKey := fmt.Sprintf("before_%d", itemIndex)
if saveName, ok := filesMap[beforeKey]; ok {
cItem.BeforeImage = fmt.Sprintf("/api/comparison/%s/images/%s", shareID, saveName)
cItem.HasBefore = true
}
afterKey := fmt.Sprintf("after_%d", itemIndex)
if saveName, ok := filesMap[afterKey]; ok {
cItem.AfterImage = fmt.Sprintf("/api/comparison/%s/images/%s", shareID, saveName)
cItem.HasAfter = true
}
items = append(items, cItem)
}
title := strings.TrimSpace(metaReq.Title)
if title == "" {
title = fmt.Sprintf("Batch Comparison (%d results)", len(items))
}
var avgLatency int64
if len(items) > 0 {
avgLatency = totalLatency / int64(len(items))
}
shareData := ComparisonShare{
ID: shareID,
Title: title,
Endpoint: metaReq.Endpoint,
SpaceName: metaReq.SpaceName,
CreatedAt: time.Now().UTC().Format(time.RFC3339),
Total: len(items),
SuccessCount: successCount,
ErrorCount: errorCount,
AvgLatency: avgLatency,
Items: items,
}
metaPath := filepath.Join(compDir, "meta.json")
if err := atomicWriteJSON(metaPath, shareData); err != nil {
slog.Error("failed to save comparison meta", "path", metaPath, "error", err)
writeJSON(w, http.StatusInternalServerError, map[string]any{"success": false, "error": "Failed to save comparison meta"})
return
}
slog.Info("created shareable comparison via fast multipart", "share_id", shareID, "items_count", len(items))
writeJSON(w, http.StatusOK, map[string]any{
"success": true,
"shareId": shareID,
"url": "/tool/bulk-api-tester/compare/" + shareID,
"directUrl": "/compare/" + shareID,
"total": len(items),
})
}