fix(khira): fix continuous error assignment modal closing bug and state preservation
This commit is contained in:
+124
-32
@@ -349,38 +349,130 @@ function resolveD(id){
|
||||
}});
|
||||
}
|
||||
function reportErr(prefill={}){
|
||||
const hasApp=!!prefill.app_name;
|
||||
dlg({wide:1,title:'Report error',sub:hasApp?`Testing Phase · Logging for ${prefill.app_name}`:'Log a runtime error for triage.',ok:'Report error',
|
||||
body:`<div class="g2">${fld('app_name','Application',{t:'select',opts:[['','Select application'],...EAPPS],req:1,v:prefill.app_name||''})}${fld('environment','Environment',{t:'select',opts:['Production','Staging','Development'],v:prefill.environment||'Production'})}</div>
|
||||
<div class="g2">${fld('service','Service / Feature',{req:1,v:prefill.service||''})}${fld('endpoint','Endpoint / Route',{v:prefill.endpoint||''})}</div>
|
||||
<div class="g2">${fld('exception_type','Exception type',{req:1,v:prefill.exception_type||''})}${fld('assigned_to','Assign developer (optional)',{t:'select',opts:usOpts(1),v:prefill.assigned_to||''})}</div>
|
||||
<div><p class="lbl">Severity</p>${rad('severity',SEV,prefill.severity||'HIGH')}</div>
|
||||
${fld('message','Message',{req:1,v:prefill.message||''})}
|
||||
${fld('stack_trace','Stack trace',{t:'area',rows:4,mono:1,v:prefill.stack_trace||''})}
|
||||
${fld('payload','Request payload',{t:'area',rows:2,mono:1,v:prefill.payload||''})}
|
||||
<div style="margin-top:12px;padding:12px 14px;background:var(--sc);border-radius:12px;border:1px solid var(--out-v)">
|
||||
<label style="display:flex;align-items:center;gap:10px;cursor:pointer;font-size:14px">
|
||||
<input type="checkbox" name="continue_app" value="1" ${prefill.continue_app?'checked':''}>
|
||||
<span><b>Continue logging for this application</b> (keeps application & service selected for rapid error entry)</span>
|
||||
</label>
|
||||
</div>`,
|
||||
alt:['Save & Log Another', async()=>{
|
||||
const f=$('#dlg form');if(!chk(f))return;
|
||||
const v=Object.fromEntries([...new FormData(f)].map(([k,x])=>[k,typeof x==='string'?x.trim():x]));
|
||||
const r=await api('/khira/api/errors','POST',{...v,app_name:v.app_name||v.app,request_payload:v.payload,assigned_to:v.assigned_to});
|
||||
if(r._f||typeof r.error==='string'){toast(r.error||'Could not report error','err');return}
|
||||
toast(`${r.error?.id||'Error'} logged for ${v.app_name}`);
|
||||
await refresh();nav('errors');
|
||||
reportErr({app_name:v.app_name,environment:v.environment,service:v.service,assigned_to:v.assigned_to,continue_app:true});
|
||||
}],
|
||||
go:async v=>{
|
||||
const r=await api('/khira/api/errors','POST',{...v,app_name:v.app_name||v.app,request_payload:v.payload,assigned_to:v.assigned_to});
|
||||
if(r._f||typeof r.error==='string'){toast(r.error||'Could not report error','err');return false}
|
||||
toast(`${r.error?.id||'Error'} reported`);await refresh();nav('errors');
|
||||
if(v.continue_app==='1'||v.continue_app===true){
|
||||
reportErr({app_name:v.app_name,environment:v.environment,service:v.service,assigned_to:v.assigned_to,continue_app:true});
|
||||
}
|
||||
}});
|
||||
const appList=Array.from(new Set([
|
||||
...(prefill.app_name?[prefill.app_name]:[]),
|
||||
...EAPPS,
|
||||
...(S.t||[]).map(t=>t.app||t.app_name),
|
||||
...(S.e||[]).map(e=>e.app||e.app_name)
|
||||
].filter(Boolean)));
|
||||
|
||||
const isCont=!!(prefill.continue_app||prefill.app_name);
|
||||
let sessionLogged=0;
|
||||
|
||||
dlg({
|
||||
wide:1,
|
||||
title:'Report & Assign Error',
|
||||
sub:prefill.app_name?`Testing Session · ${esc(prefill.app_name)}`:'Log runtime errors and assign directly to developers.',
|
||||
ok:'Assign & Finish',
|
||||
alt:['Assign & Log Next',null],
|
||||
body:`
|
||||
<div id="contAppBanner" class="cont-banner" style="${isCont?'':'display:none'}">
|
||||
<span class="ms">sync</span>
|
||||
<div>
|
||||
<b>Continuous Error Assignment Active</b>
|
||||
<p id="contStatus">Application locked for rapid entry · Errors assigned this session: <span id="contCount">0</span></p>
|
||||
</div>
|
||||
</div>
|
||||
<div class="g2">
|
||||
${fld('app_name','Application',{t:'select',opts:[['','Select application'],...appList],req:1,v:prefill.app_name||''})}
|
||||
${fld('assigned_to','Assign Developer (Optional)',{t:'select',opts:usOpts(1),v:prefill.assigned_to||''})}
|
||||
</div>
|
||||
<div class="g2">
|
||||
${fld('environment','Environment',{t:'select',opts:['Production','Staging','Development'],v:prefill.environment||'Production'})}
|
||||
${fld('service','Service / Subsystem',{req:1,v:prefill.service||''})}
|
||||
</div>
|
||||
<div class="g2">
|
||||
${fld('exception_type','Exception Type',{req:1,v:prefill.exception_type||''})}
|
||||
${fld('endpoint','Endpoint / Route',{v:prefill.endpoint||''})}
|
||||
</div>
|
||||
<div>
|
||||
<p class="lbl">Severity</p>
|
||||
${rad('severity',SEV,prefill.severity||'HIGH')}
|
||||
</div>
|
||||
${fld('message','Error Message',{req:1,v:prefill.message||''})}
|
||||
${fld('stack_trace','Stack Trace',{t:'area',rows:4,mono:1,v:prefill.stack_trace||''})}
|
||||
${fld('payload','Request Payload',{t:'area',rows:2,mono:1,v:prefill.payload||''})}
|
||||
<div style="margin-top:12px;padding:12px 14px;background:var(--sc);border-radius:12px;border:1px solid var(--out-v)">
|
||||
<label style="display:flex;align-items:center;gap:10px;cursor:pointer;font-size:14px">
|
||||
<input type="checkbox" id="chkContinueApp" name="continue_app" value="1" ${isCont?'checked':''}>
|
||||
<span><b>Continuous Assignment Mode</b> (keep application & developer selected to continue adding errors)</span>
|
||||
</label>
|
||||
</div>
|
||||
`,
|
||||
init:f=>{
|
||||
const banner=f.querySelector('#contAppBanner');
|
||||
const countEl=f.querySelector('#contCount');
|
||||
const contChk=f.querySelector('#chkContinueApp');
|
||||
const altBtn=f.querySelector('[data-alt]');
|
||||
const cancelBtn=f.querySelector('[data-x]');
|
||||
|
||||
contChk?.addEventListener('change',()=>{
|
||||
if(banner)banner.style.display=contChk.checked?'flex':'none';
|
||||
});
|
||||
|
||||
async function executeSubmit(keepOpen){
|
||||
if(!chk(f))return false;
|
||||
const v=Object.fromEntries([...new FormData(f)].map(([k,x])=>[k,typeof x==='string'?x.trim():x]));
|
||||
const submitBtn=keepOpen?altBtn:f.querySelector('.fb');
|
||||
|
||||
return await busy(submitBtn,async()=>{
|
||||
const r=await api('/khira/api/errors','POST',{
|
||||
...v,
|
||||
app_name:v.app_name||v.app,
|
||||
request_payload:v.payload,
|
||||
assigned_to:v.assigned_to
|
||||
});
|
||||
if(r._f||typeof r.error==='string'){
|
||||
toast(r.error||'Could not report error','err');
|
||||
return false;
|
||||
}
|
||||
|
||||
sessionLogged++;
|
||||
const ticketMsg=r.ticket?` · Assigned to ${r.ticket.assigned_to_name||v.assigned_to} (${r.ticket.id})`:'';
|
||||
toast(`${r.error?.id||'Error'} recorded${ticketMsg}`);
|
||||
await refresh();
|
||||
|
||||
if(keepOpen){
|
||||
if(banner)banner.style.display='flex';
|
||||
if(contChk)contChk.checked=true;
|
||||
if(countEl)countEl.textContent=sessionLogged;
|
||||
if(cancelBtn)cancelBtn.textContent=`Done (${sessionLogged} logged)`;
|
||||
|
||||
// Clear ONLY bug-specific details, keeping app and developer
|
||||
const exc=f.querySelector('input[name="exception_type"]');
|
||||
const msg=f.querySelector('input[name="message"]');
|
||||
const st=f.querySelector('textarea[name="stack_trace"]');
|
||||
const pl=f.querySelector('textarea[name="payload"]');
|
||||
if(exc)exc.value='';
|
||||
if(msg)msg.value='';
|
||||
if(st)st.value='';
|
||||
if(pl)pl.value='';
|
||||
f.querySelectorAll('.bad').forEach(el=>el.classList.remove('bad'));
|
||||
|
||||
if(exc)exc.focus();
|
||||
return false;
|
||||
}else{
|
||||
$('#dlg').close();
|
||||
nav('errors');
|
||||
return true;
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
if(altBtn){
|
||||
altBtn.onclick=async()=>{
|
||||
await executeSubmit(true);
|
||||
};
|
||||
}
|
||||
|
||||
f.onsubmit=async e=>{
|
||||
e.preventDefault();
|
||||
const keepOpen=contChk?contChk.checked:false;
|
||||
await executeSubmit(keepOpen);
|
||||
};
|
||||
},
|
||||
go:()=>false
|
||||
});
|
||||
}
|
||||
|
||||
/* ── admin database sync & rollback ── */
|
||||
|
||||
@@ -331,5 +331,13 @@ dt{font-size:12px;color:var(--on-sv)}dd{word-break:break-word}
|
||||
.err-testing-banner p{font-size:13px;color:var(--on-sv);margin:0}
|
||||
.err-testing-banner b{color:var(--on-s)}
|
||||
|
||||
/* Continuous error logging in-dialog banner */
|
||||
.cont-banner{background:var(--pri-c);border:1px solid var(--pri);border-radius:12px;padding:10px 14px;margin-bottom:14px;display:flex;align-items:center;gap:12px;font-size:13px}
|
||||
.cont-banner .ms{font-size:22px;color:var(--pri)}
|
||||
.cont-banner b{font-size:13px;color:var(--on-s);display:block}
|
||||
.cont-banner p{margin:2px 0 0;font-size:12px;color:var(--on-sv)}
|
||||
.cont-badge{display:inline-flex;align-items:center;gap:6px;background:var(--sec-c);color:var(--on-s);padding:2px 8px;border-radius:12px;font-size:11px;font-weight:600}
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user